Conversation
durera
reviewed
Dec 30, 2025
durera
requested changes
Feb 18, 2026
| # Use MAS default self-signed cluster issuer with the default domain | ||
| self.setParam("dns_provider", "") | ||
| self.setParam("mas_domain", "") | ||
| self.setParam("mas_cluster_issuer", "") |
Contributor
There was a problem hiding this comment.
What's the reason we don't need this set to empty here now, wouldn't we still want this set to "" in this case?
| self.manualCertsDir = None | ||
| else: | ||
| # Configuring domain | ||
| if self.yesOrNo('Configure custom domain'): |
Contributor
There was a problem hiding this comment.
I find the current flow a bit confusing ...
Do you want to configure domain and cert management? No
Do you want to configure custom domain? Yes
Feel like most customers would have answered Yes to the first one, even if they wanted what's in the second path.
Think we should have a single path through this taking customers through the options, with a single prompt asking them to pick how they want to manage the certs:
if (Do you want to configure domain and cert management?)
Configure custom domain
Choose certificate management mode
1. Certificate-Manager with DNS integration
2. Certificate-Manager with existing ClusterIssuer
3. Certificate-Manager with auto-generated self-signed certificate
4. Manual certificate management
>
This can then be easily extended by @rawa-resul for his work to add support for Issuer as an alternative to ClusterIssuer.
durera
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
mas install#1812Changes
mas_cluster_issuerparameter.Tests
Override without provider
Override with provider - CIS
No override with no provider
No override with a provider - CIS